Improved unit tests for open_maybe_zipped function.#14114
Improved unit tests for open_maybe_zipped function.#14114ashb merged 4 commits intoapache:masterfrom
Conversation
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The pylint and k8s test errors appear to be completely unrelated to what's in this PR. Seems to be something that came from master. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
CI are sad. Can you do a rebase? |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
The CI pipelines cancelled with error: "The self-hosted runner: Airflow Runner 60 lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error." I don't think it's under my control. Can you restart the build? (Or let me know if I can restart it e.g. with special comments.) |
This PR is to address requests formulated in the comments to PR #13984. Namely:
airflow.utils.fileunit tests moved out oftest_dag_processing.pyinto its own moduletest_file.py.open_maybe_zippedfunction unit test, instead of relying on mocks, now actually reads a test file contents, zipped and plain, and verifies that the returned file content is string in both cases.