Update google-cloud-secret-manager-backend.rst #14164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"airflow-tenant-primary" is a bit confusing, and the examples don't match up in the configuration file example. fix "connections_prefix" and "variables_prefix" mixup in first unordered list in "Managing Secrets" section make "variable_prefix" plural for consistency
dstandish
approved these changes
Feb 10, 2021
kaxil
approved these changes
Feb 10, 2021
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"airflow-tenant-primary" is a bit confusing, and the examples don't match up in the configuration file example, so I changed it to "example-variables-prefix" and "example-connections-prefix".
fix "connections_prefix" and "variables_prefix" mixup in first unordered list in "Managing Secrets" section
make "variable_prefix" plural for consistency