Fix the AzureContainerInstanceOp _monitor_logging method to sleep properly #14213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the AzureContainerInstancesOperator in our production instance we noticed very high CPU usage and lots of issues related to getting the state of the container. This would lead to jobs being spun up and completing but Airflow thinking they failed because it timed out trying to get the logs/exit status. Upon further inspection it looked like it was coming from this function, which we confirmed with the fixes in this PR that we now use in our own environment. CPU Usage has dropped dramatically and we're no longer getting errors around the status of the container.
The main fix is just simply moving the sleep to the correct scope and increasing it slightly, the other "just to be extra safe" fix is to check that the event stream is not None before trying to iterate over it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.