Skip to content

Conversation

@ThomasLaPiana
Copy link

@ThomasLaPiana ThomasLaPiana commented Feb 12, 2021

When running the AzureContainerInstancesOperator in our production instance we noticed very high CPU usage and lots of issues related to getting the state of the container. This would lead to jobs being spun up and completing but Airflow thinking they failed because it timed out trying to get the logs/exit status. Upon further inspection it looked like it was coming from this function, which we confirmed with the fixes in this PR that we now use in our own environment. CPU Usage has dropped dramatically and we're no longer getting errors around the status of the container.

The main fix is just simply moving the sleep to the correct scope and increasing it slightly, the other "just to be extra safe" fix is to check that the event stream is not None before trying to iterate over it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:microsoft-azure Azure-related issues label Feb 12, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 12, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@ashb ashb changed the title Fix the _monitor_logging method to sleep properly Fix the AzureContainerInstanceOp _monitor_logging method to sleep properly Feb 15, 2021
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 25, 2021
@github-actions github-actions bot closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:microsoft-azure Azure-related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant