Skip to content

clean up gantt js#14545

Merged
ryanahamilton merged 1 commit intoapache:masterfrom
astronomer:update-gantt-js
Mar 1, 2021
Merged

clean up gantt js#14545
ryanahamilton merged 1 commit intoapache:masterfrom
astronomer:update-gantt-js

Conversation

@bbovenzi
Copy link
Copy Markdown
Contributor

@bbovenzi bbovenzi commented Mar 1, 2021

Continuation of #14115.

  • Remove most inline js for the Gantt chart.
  • Linting all Gantt js
  • Use more conventional file name

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Remove most inline js for the Gantt chart.
Linting all Gantt js
Use more conventional file name
@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 1, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 1, 2021
@ryanahamilton ryanahamilton merged commit a9314dd into apache:master Mar 1, 2021
@ryanahamilton ryanahamilton deleted the update-gantt-js branch March 1, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants