Skip to content

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Mar 9, 2021

Add optional job labels to bigquery check operators. Checks can be expensive, so it would be useful to be able to annotate check queries with job labels for later analysis as with other bigquery operators.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@jmcarp jmcarp force-pushed the jmcarp/bigquery-check-labels branch from 06ad4fc to 72d8340 Compare March 10, 2021 02:51
@jmcarp jmcarp force-pushed the jmcarp/bigquery-check-labels branch from 72d8340 to c36c98b Compare March 10, 2021 04:36
@jmcarp jmcarp requested review from ashb and kaxil and removed request for kaxil March 10, 2021 14:21
@jmcarp jmcarp marked this pull request as ready for review March 10, 2021 14:21
@jmcarp
Copy link
Contributor Author

jmcarp commented Mar 10, 2021

Does this approach make sense @kaxil @ashb? There's a lot of indirection from the check operators to the base class and mixin to the bigquery dbapi shim, and this was the simplest thing I could think of.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 10, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@jmcarp jmcarp merged commit 943baff into apache:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants