Skip to content

Add Guide to release Apache Airflow Upgrade Check#14690

Merged
kaxil merged 1 commit intoapache:masterfrom
astronomer:add-upgrade-check-release-guide
Mar 15, 2021
Merged

Add Guide to release Apache Airflow Upgrade Check#14690
kaxil merged 1 commit intoapache:masterfrom
astronomer:add-upgrade-check-release-guide

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Mar 10, 2021

This commit adds guide to release Apache Airflow Upgrade Check


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil force-pushed the add-upgrade-check-release-guide branch 2 times, most recently from 2f82e42 to 6aed21d Compare March 14, 2021 01:04
@kaxil kaxil marked this pull request as ready for review March 14, 2021 01:04
@kaxil kaxil requested a review from potiuk as a code owner March 14, 2021 01:04
@kaxil
Copy link
Member Author

kaxil commented Mar 14, 2021

ping @potiuk @ashb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I should release this to pypi!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to run egg_info command manually, sdist will do that automatically I thought

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, egg_info is only needed when preparing the pypi snapshot so that we can pass --tag-build option, but we shouldn't need it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```shell
```shell script

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased

Comment on lines 201 to 203
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops copy paste error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add .rat-excludes too

Suggested change
airflow/upgrade NOTICE LICENSE licenses/
airflow/upgrade NOTICE LICENSE licenses/ .rat-excludes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```shell
```shell script

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and rebased

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Future enhancement: We should really work out how to just release the artifacts we votes on, rather than build new ones)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should simply take the packages we vote on from SVN after we renamed them. I see no reason why it should not work. It should work the same for airflow, upgrade check and providers.

This commit adds guide to release Apache Airflow Upgrade Check
@kaxil kaxil force-pushed the add-upgrade-check-release-guide branch from 6aed21d to 230582f Compare March 15, 2021 17:14
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 15, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit 251eb7d into apache:master Mar 15, 2021
@kaxil kaxil deleted the add-upgrade-check-release-guide branch March 15, 2021 18:34
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small NIT

Subject:

```
[VOTE] Release apache-airflow-upgrade-check 1.3.0 from 1.3.0rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good to your VERSION from variable? I am not sure if we ever do it again but replacing the version is kinda easy to miss .

<https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#verify-release-candidates-by-contributors>,
but again, this time it is a little bit different.

To actually use this command you will need apache-airflow 1.10.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To actually use this command you will need apache-airflow 1.10.14
To actually use this command you will need apache-airflow 1.10.15

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should simply take the packages we vote on from SVN after we renamed them. I see no reason why it should not work. It should work the same for airflow, upgrade check and providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants