Suggest using $http_host instead of $host#14814
Merged
Merged
Conversation
If the reverse proxy is not running in port 80, using $host won't forward the port in the HTTP request to airflow and it won't build the correct redirect URL. E.g. I have nginx and airflow running in docker in the default ports. My mapping for nginx x is 7003:80. The request http://myserver:7003/myorg/airflow/ will redirect to http://myserver/myorg/airflow/admin/ instead of http://myserver:7003/myorg/airflow/admin/.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
@ad-m Can you look at it? |
ad-m
approved these changes
Mar 15, 2021
Contributor
ad-m
left a comment
ad-m
left a comment
There was a problem hiding this comment.
nginx-proxy/nginx-proxy use $http_host, but see comment in nginx-proxy/nginx-proxy#763
ianstanton
approved these changes
Mar 16, 2021
mik-laj
approved these changes
Mar 16, 2021
|
Awesome work, congrats on your first merged pull request! |
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
If the reverse proxy is not running in port 80, using $host won't forward the port in the HTTP request to airflow and it won't build the correct redirect URL. E.g. I have nginx and airflow running in docker in the default ports. My mapping for nginx x is 7003:80. The request http://myserver:7003/myorg/airflow/ will redirect to http://myserver/myorg/airflow/admin/ instead of http://myserver:7003/myorg/airflow/admin/. (cherry picked from commit 9cb6553)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
If the reverse proxy is not running in port 80, using $host won't forward the port in the HTTP request to airflow and it won't build the correct redirect URL. E.g. I have nginx and airflow running in docker in the default ports. My mapping for nginx x is 7003:80. The request http://myserver:7003/myorg/airflow/ will redirect to http://myserver/myorg/airflow/admin/ instead of http://myserver:7003/myorg/airflow/admin/. (cherry picked from commit 9cb6553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the reverse proxy is not running in port 80, using $host won't forward the port in the HTTP request to airflow and it won't build the correct redirect URL.
E.g.
I have nginx and airflow running in docker in the default ports. My mapping for nginx x is 7003:80.
The request http://myserver:7003/myorg/airflow/ will redirect to http://myserver/myorg/airflow/admin/ instead of http://myserver:7003/myorg/airflow/admin/.