Skip to content

Update metadataConnection to be postgres container default.#14849

Closed
madden1706 wants to merge 1 commit intoapache:masterfrom
madden1706:local_dev_postgres
Closed

Update metadataConnection to be postgres container default.#14849
madden1706 wants to merge 1 commit intoapache:masterfrom
madden1706:local_dev_postgres

Conversation

@madden1706
Copy link

The local postgres container password default does not seem to be correct.
Updated this so the airflow containers will be able to access the database.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 17, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ashb
Copy link
Member

ashb commented Mar 17, 2021

@ianstanton related to switching the postgres subchart maybe?

@ianstanton
Copy link
Contributor

Hmm that value should be set here:

postgresqlPassword: postgres

I'll take a closer look

@ianstanton
Copy link
Contributor

@madden1706 Could you provide steps to reproduce and environment details? I am able to run successfully with default values on a GKE cluster. Thanks!

@madden1706
Copy link
Author

Hi, I've deleted and recreated my minikube cluster. Seems to have solved - I'll close this.

@madden1706 madden1706 closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants