Skip to content

Add ability to specify api group and version for Spark operators#14898

Merged
kaxil merged 1 commit intoapache:masterfrom
akrava:feature-customize-api-group-and-version-spark-k8s-operator-branch
Mar 20, 2021
Merged

Add ability to specify api group and version for Spark operators#14898
kaxil merged 1 commit intoapache:masterfrom
akrava:feature-customize-api-group-and-version-spark-k8s-operator-branch

Conversation

@akrava
Copy link
Copy Markdown
Contributor

@akrava akrava commented Mar 19, 2021

closes: #14897
There were added two parameters for SparkKubernetesOperator and SparkKubernetesSensor. I've placed them in the end and provided default values, so there will be backward compatibility.
Also added description and tests.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Mar 19, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Mar 19, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@akrava akrava changed the title Add avility to specify api group and version for Spark operators Add ability to specify api group and version for Spark operators Mar 19, 2021
@kaxil kaxil merged commit 00453dc into apache:master Mar 20, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Mar 20, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to specify API group and version for Spark operators

2 participants