Upgrade rule to suggest to rename max_threads to parsing_processes #14913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested changes
Mar 22, 2021
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Thanks @mcepok for the PR, 1 change in test suggested
Comment on lines
36
to
38
| # Remove the fallback option | ||
| conf.deprecated_options.get("scheduler", {}).pop("parsing_processes", "") | ||
| conf.remove_option("scheduler", "parsing_processes") |
Member
There was a problem hiding this comment.
Yeah we should not do this and mock it instead as it causes side effects and other tests are failing, example: https://github.com/apache/airflow/pull/14913/checks?check_run_id=2155532411#step:6:960
Contributor
Author
There was a problem hiding this comment.
I see, thanks for the feedback. I adjusted the tests with mocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an upgrade rule as described in #12672 to rename the max_threads configuration to parsing_processes.
I created this rule on the example of the
LoggingConfigurationRule, which doesn't suggest any changes if the old configuration exists but has the default value. I assume, that the idea behind this is, that if the configuration is not set by the user, a default configuration is taken. However, if a user explicitly copied the default configuration in his or her own configuration, in my opinion, a change should be suggested but isn't. But maybe I misunderstood something.