Fixes default group of Airflow user. #14944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The production image did not have root group set as default for the airflow user. This was not a big problem unless you extended the image - in which case you had to change the group manually when copying the images in order to keep the image OpenShift compatible (i.e. runnable with any user and root group). This PR fixes it by changing default group of airflow user to root, which also works when you extend the image. ``` Connected. airflow@53f70b1e3675:/opt/airflow$ ls dags logs airflow@53f70b1e3675:/opt/airflow$ cd dags/ airflow@53f70b1e3675:/opt/airflow/dags$ ls -l total 4 -rw-r--r-- 1 airflow root 1648 Mar 22 23:16 test_dag.py airflow@53f70b1e3675:/opt/airflow/dags$ ```
potiuk
requested review from
ashb,
kaxil,
mik-laj and
vikramkoka
as code owners
mik-laj
approved these changes
Mar 23, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Mar 23, 2021
potiuk
added a commit
that referenced
this pull request
Mar 23, 2021
The production image did not have root group set as default for the airflow user. This was not a big problem unless you extended the image - in which case you had to change the group manually when copying the images in order to keep the image OpenShift compatible (i.e. runnable with any user and root group). This PR fixes it by changing default group of airflow user to root, which also works when you extend the image. ``` Connected. airflow@53f70b1e3675:/opt/airflow$ ls dags logs airflow@53f70b1e3675:/opt/airflow$ cd dags/ airflow@53f70b1e3675:/opt/airflow/dags$ ls -l total 4 -rw-r--r-- 1 airflow root 1648 Mar 22 23:16 test_dag.py airflow@53f70b1e3675:/opt/airflow/dags$ ```
potiuk
added a commit
that referenced
this pull request
Mar 25, 2021
The production image did not have root group set as default for the airflow user. This was not a big problem unless you extended the image - in which case you had to change the group manually when copying the images in order to keep the image OpenShift compatible (i.e. runnable with any user and root group). This PR fixes it by changing default group of airflow user to root, which also works when you extend the image. ``` Connected. airflow@53f70b1e3675:/opt/airflow$ ls dags logs airflow@53f70b1e3675:/opt/airflow$ cd dags/ airflow@53f70b1e3675:/opt/airflow/dags$ ls -l total 4 -rw-r--r-- 1 airflow root 1648 Mar 22 23:16 test_dag.py airflow@53f70b1e3675:/opt/airflow/dags$ ```
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
The production image did not have root group set as default for the airflow user. This was not a big problem unless you extended the image - in which case you had to change the group manually when copying the images in order to keep the image OpenShift compatible (i.e. runnable with any user and root group). This PR fixes it by changing default group of airflow user to root, which also works when you extend the image. ``` Connected. airflow@53f70b1e3675:/opt/airflow$ ls dags logs airflow@53f70b1e3675:/opt/airflow$ cd dags/ airflow@53f70b1e3675:/opt/airflow/dags$ ls -l total 4 -rw-r--r-- 1 airflow root 1648 Mar 22 23:16 test_dag.py airflow@53f70b1e3675:/opt/airflow/dags$ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The production image did not have root group set as default for
the airflow user. This was not a big problem unless you extended
the image - in which case you had to change the group manually
when copying the images in order to keep the image OpenShift
compatible (i.e. runnable with any user and root group).
This PR fixes it by changing default group of airflow user
to root, which also works when you extend the image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.