Skip to content

Comments

Update dag-serialization.rst#14992

Merged
kaxil merged 3 commits intoapache:masterfrom
sserdyukov:patch-1
Mar 25, 2021
Merged

Update dag-serialization.rst#14992
kaxil merged 3 commits intoapache:masterfrom
sserdyukov:patch-1

Conversation

@sserdyukov
Copy link
Contributor

Fixing minor stylistic mistakes and some typos


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Fixing minor stylistic mistakes and some typos
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 24, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@sserdyukov sserdyukov requested a review from kaxil March 25, 2021 07:15
@kaxil kaxil merged commit ce37b01 into apache:master Mar 25, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 25, 2021

Awesome work, congrats on your first merged pull request!

@sserdyukov sserdyukov deleted the patch-1 branch March 25, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants