Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 25, 2021

closes: #15010

Right now this operator is not able to return any query result.
It should be allowed to do so in order to use them to retrieve useful data and use it in the following nodes

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Please add some unit tests too.

Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 26, 2021

The DBApiHook run doesn't return anything.
Reading the documentation:

Runs a command or a list of commands. Pass a list of sql
       statements to the sql parameter to get them to execute
       sequentially

you can send a list of sql statements to run, how do you proceed with this?
Maybe some logic using the function get_records could be better...

This look a very nice use with the TaskFlow API. Others users must know about this. Please, if possible add example and improve documentation to demonstrate to others.

@ghost
Copy link
Author

ghost commented Mar 26, 2021

Hi @marcosmarxm

The DBApiHook run doesn't return anything

Method overriding in Python is perfectly fine with different return types when using inheritance. I guess that the fact that Python does not support overloading helps to prevent these issues.

you can send a list of sql statements to run, how do you proceed with this?

I'll make some tests and I'll get back to you.

Thank you for the feedback

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 11, 2021
@github-actions github-actions bot closed this May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow PostgreSQL's operator to return the query result

2 participants