Skip to content

Add more strict Helm Chart schema checks for image pullPolicy & dags accessMode#15040

Merged
kaxil merged 1 commit intoapache:masterfrom
XD-DENG:enhance-helm-chart-schema-check
Mar 26, 2021
Merged

Add more strict Helm Chart schema checks for image pullPolicy & dags accessMode#15040
kaxil merged 1 commit intoapache:masterfrom
XD-DENG:enhance-helm-chart-schema-check

Conversation

@XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 26, 2021

values.schema.json can be used to help check the structure & the values in values.yaml.

  • In this PR I extend the values.schema.json to ensure we have more strict checks on the values users add in values.yaml.
  • Tests are added.

@XD-DENG XD-DENG added the area:helm-chart Airflow Helm Chart label Mar 26, 2021
@XD-DENG XD-DENG requested review from ashb, kaxil and mik-laj March 26, 2021 20:39
@XD-DENG XD-DENG requested a review from dimberman as a code owner March 26, 2021 20:39
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 26, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit 28859ca into apache:master Mar 26, 2021
@XD-DENG XD-DENG deleted the enhance-helm-chart-schema-check branch March 27, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants