Skip to content

Conversation

@BorysWix
Copy link

Details #14880

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 31, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil kaxil requested a review from eladkal April 3, 2021 00:19
@mik-laj
Copy link
Member

mik-laj commented Apr 3, 2021

Can you add tests to avoid regression?

@michaelosthege
Copy link
Contributor

The code from this PR didn't work for me (using the SlackHook directly from PythonOperator).
Maybe I did something wrong, but what works for me (Airflow 2.0.1) is the code from this: https://stackoverflow.com/a/58264852/4473230

@eladkal eladkal marked this pull request as draft April 19, 2021 10:05
@eladkal
Copy link
Contributor

eladkal commented Apr 19, 2021

Borys won't be able to complete this PR

@eladkal eladkal closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants