Skip to content

Set default value for SQL_ALCHEMY_POOL_ENABLED to True#15272

Closed
cnliao wants to merge 1 commit intoapache:masterfrom
cnliao:patch-1
Closed

Set default value for SQL_ALCHEMY_POOL_ENABLED to True#15272
cnliao wants to merge 1 commit intoapache:masterfrom
cnliao:patch-1

Conversation

@cnliao
Copy link
Copy Markdown

@cnliao cnliao commented Apr 8, 2021

Set default value of SQL_ALCHEMY_POOL_ENABLED, otherwise when config file does not mention this variable it causes NullPool to be used.

Set default value of SQL_ALCHEMY_POOL_ENABLED, otherwise when config file does not mention this variable it causes NullPool to be used.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 8, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@cnliao
Copy link
Copy Markdown
Author

cnliao commented Apr 8, 2021

I understood it wrong. Closing. Sorry for the noise.

@cnliao cnliao closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant