Chart: Allow setting an existing secret for PgBouncer config#15296
Merged
kaxil merged 4 commits intoapache:masterfrom Apr 10, 2021
Merged
Chart: Allow setting an existing secret for PgBouncer config#15296kaxil merged 4 commits intoapache:masterfrom
kaxil merged 4 commits intoapache:masterfrom
Conversation
DerekHeldtWerle
requested review from
ashb,
dimberman,
kaxil,
mik-laj and
vikramkoka
as code owners
kaxil
reviewed
Apr 9, 2021
chart/values.yaml
Outdated
Member
There was a problem hiding this comment.
Suggested change
| pgbouncerConfigSecretName: ~ | |
| configSecretName: ~ |
Since it is already in pgbouncer key -- adding pgbouncer is a bit redundant. Can you also give an example of an existing config with pgbouncer.ini and users.txt
Member
|
Can you rebase on latest master and fix the conflicting files please @DerekHeldtWerle |
…cret for pgbouncers config
DerekHeldtWerle
force-pushed
the
feature/existing-pgbouncer-secret
branch
from
7dea237 to
6874f89
Compare
Contributor
Author
|
@kaxil Done 👍 |
kaxil
approved these changes
Apr 9, 2021
kaxil
changed the title
kaxil
reviewed
Apr 9, 2021
Fix static checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a user wanted to supply the username and password to the
users.txtsecret for use by pgbouncer, they had to be set directly in thevalues.yamlfile. This change allows users to create this secret out of band (with thepgbouncer.ini) and avoid supplying secrets directly.