-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Chart: Allow disabling git-sync for Webserver
#15314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Allow disabling git-sync for Webserver
#15314
Conversation
git-sync when DAG serialization is enabledgit-sync when DAG Serialization is enabled
32a92f7 to
5730690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Airflow 1.10.9 and earlier, DAG files is still needed for DAG code ttab. For Airflow 1.10.10 and newer (including 2.0.0), it is needed to enablestore_dag_code to True (default value: False). DAG Serialization is not enough.
http://airflow.apache.org/docs/apache-airflow/2.0.1/configurations-ref.html#store-dag-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had removed the default and have a fallback of True for store_dag_code for Airflow >=1.10.11
Lines 460 to 462 in 5da8319
| # Whether to persist DAG files code in DB. If set to True, Webserver reads file contents | |
| # from DB instead of trying to access files in a DAG folder. | |
| STORE_DAG_CODE = conf.getboolean("core", "store_dag_code", fallback=True) |
airflow/airflow/config_templates/default_airflow.cfg
Lines 205 to 209 in 5da8319
| # Whether to persist DAG files code in DB. | |
| # If set to True, Webserver reads file contents from DB instead of | |
| # trying to access files in a DAG folder. | |
| # Example: store_dag_code = False | |
| # store_dag_code = |
Same for 1.10.11:
where the value is same as store_serialized_dags:
https://github.com/apache/airflow/blob/1.10.11/airflow/settings.py#L431-L434
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description in fb10b09
5730690 to
fb10b09
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
fb10b09 to
0ea925f
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
|
Could you update this PR title and description please? |
git-sync when DAG Serialization is enabledgit-sync for Webserver
closes #11704
When DAG Serialization is enabled for
Airflow >= 1.10.10, <2.0, we don't need to rungit-synccontainer for Webserver as DAGs are fetched from Database. DAG Serialization is enabled forAirflow > 2so users should be able to stop running §git-sync` containers for Webserver when by running:helm upgrade airflow . \ --set dags.gitSync.enabled=true \ --set dags.gitSync.excludeWebserver=true^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.