Skip to content

Do not forward cluster-identifier to psycopg2#15360

Merged
dstandish merged 1 commit intoapache:masterfrom
zhzhang:master
Apr 14, 2021
Merged

Do not forward cluster-identifier to psycopg2#15360
dstandish merged 1 commit intoapache:masterfrom
zhzhang:master

Conversation

@zhzhang
Copy link
Contributor

@zhzhang zhzhang commented Apr 14, 2021

Do not forward cluster-identifier parameter to psycopgy2

Cluster ID is used by botocore to fetch Redshift credentials only, and will result in

psycopg2.ProgrammingError: invalid dsn: invalid connection option "cluster-identifier"

if subsequently passed to the postgres connection constructor.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 14, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dstandish dstandish changed the title Do not forward cluster-identifier to psycopgy2 Do not forward cluster-identifier to psycopg2 Apr 14, 2021
@dstandish dstandish merged commit 70c74c1 into apache:master Apr 14, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 14, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants