Skip to content

Conversation

@bryce-lewis
Copy link
Contributor

Added params and descriptions to docstrings to improve documentation of the following modules

  • MySqlHook
  • RedshiftHook
  • CloudSQLHook
  • BigQueryHook
  • OracleHook
  • MongoHook
  • HdfsSensor
  • ZendeskHook
  • ElasticsearchHook

@bryce-lewis bryce-lewis requested a review from turbaszek as a code owner April 15, 2021 21:10
@boring-cyborg boring-cyborg bot added area:providers provider:Apache provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Apr 15, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@sunkickr sunkickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some trailing white spaces that need cleaned up

@kaxil kaxil merged commit 71c673e into apache:master Apr 22, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 22, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants