Skip to content

Fix AWSAthenaHook hook usage in AthenaSensor#15427

Merged
feluelle merged 1 commit intoapache:masterfrom
Tonkonozhenko:patch-1
Apr 26, 2021
Merged

Fix AWSAthenaHook hook usage in AthenaSensor#15427
feluelle merged 1 commit intoapache:masterfrom
Tonkonozhenko:patch-1

Conversation

@Tonkonozhenko
Copy link
Copy Markdown
Contributor

Incorrect parameters in calling AWSAthenaHook

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Apr 19, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 19, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Tonkonozhenko Tonkonozhenko force-pushed the patch-1 branch 3 times, most recently from d8f84c5 to 62c595d Compare April 21, 2021 09:08
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 26, 2021
@github-actions
Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@feluelle feluelle merged commit d598630 into apache:master Apr 26, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 26, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants