Chart: Fix passing upgrading strategies to Celery Worker #15477
Conversation
kaxil
force-pushed
the
fix-celerty
branch
3 times, most recently
from
1f82efe to
1743bc2
Compare
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
We create a Statefulset if persistence is enabled and Deployment otherwise. Upgrading strategies are different for both those types of resources. Statefulst needs `updateStrategy`, deployment needs `strategy`. Without this fix, using Helm Chart with CeleryExecutor failed with ``` helm install airflow -n airflow --set executor=CeleryExecutor --set images.airflow.repository=k8s-dags --set images.airflow.tag=1.0.2 . Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(StatefulSet.spec): unknown field "strategy" in io.k8s.api.apps.v1.StatefulSetSpec ```
4 participants
We create a Statefulset if persistence is enabled and Deployment
otherwise. Upgrading strategies are different for both those types
of resources.
Statefulst needs
updateStrategy, deployment needsstrategy.Without this fix, using Helm Chart with CeleryExecutor failed with
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.