Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 22, 2021

While cherry-picking docker image changei to v2-0-test, the
value of the arg was wrongly rename (similarly to other parameters) with
constraintis-2.0 where it should remain as constraints.
This is the name of constraint file to use, and it's value might
be either constraints-no-providers, constraints, or
constraints-source-providers.

This change restores proper default of the arg.

Fixes: #15493


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

While cherry-picking docker image changei to v2-0-test, the
value of the arg was wrongly rename (similarly to other parameters) with
`constraintis-2.0` where it should remain as `constraints`.
This is the name of constraint file to use, and it's value might
be either `constraints-no-providers`, `constraints`, or
`constraints-source-providers`.

This change restores proper default of the arg.

Fixes: apache#15493
@potiuk potiuk requested review from ashb and kaxil April 22, 2021 21:23
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 22, 2021
@potiuk potiuk merged commit 88199ee into apache:v2-0-stable Apr 22, 2021
@potiuk potiuk deleted the fix-cherry-pick-problem-with-default-arg branch April 22, 2021 21:31
@potiuk potiuk restored the fix-cherry-pick-problem-with-default-arg branch April 26, 2022 20:51
@potiuk potiuk deleted the fix-cherry-pick-problem-with-default-arg branch July 29, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants