Chart: Update Webserver update strategy based on Airflow Version #15627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested changes
May 4, 2021
kaxil
force-pushed
the
add-airflow-version
branch
2 times, most recently
from
804e254 to
70f3d19
Compare
jedcunningham
approved these changes
May 5, 2021
ephraimbuddy
approved these changes
May 6, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
This commit adds the following things: - Add "airflowVersion" flag that will allow use to add some components that are just available or work with certain Airflow version. Example: pod_template_file is available for Airflow >= 1.10.12 - Update logic for selecting pre/post Airflow 2.0 CLI commands based on that flag - Updates stragtegy of Airflow Webserver based on that flag as the webserver in Airflow >= 2 does not need access to DAG files, hence we don't need to recreate but can have a "true" rollingUpdate - Allow overriding webserver udpate strategy
kaxil
force-pushed
the
add-airflow-version
branch
2 times, most recently
from
5898987 to
a8610a5
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 13, 2021
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache#15627 - we now have `airflowVerson` so we can just do a comparison of the version.
kaxil
added a commit
that referenced
this pull request
May 13, 2021
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with #15627 - we now have `airflowVerson` so we can just do a comparison of the version.
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 9, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 13, 2024
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 1, 2025
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 22, 2025
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2025
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 16, 2025
For `apache-airflow>=2.0.0`, DAG Serialization is enabled by default and we don't need to have a sidecar on Websserver. Previously this was done using `gitSync.excludeWebserver`. However with apache/airflow#15627 - we now have `airflowVerson` so we can just do a comparison of the version. GitOrigin-RevId: caddbf3aa04096033502d7da7eafaf830737a9b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the following things:
that are just available or work with certain Airflow version.
Example: pod_template_file is available for Airflow >= 1.10.12
on that flag
webserver in Airflow >= 2 does not need access to DAG files, hence
we don't need to recreate but can have a "true" rollingUpdate
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.