Skip to content

[AIRFLOW-211] Fix JIRA "resolve" vs "close" behavior#1571

Closed
jlowin wants to merge 1 commit intoapache:masterfrom
jlowin:pr-tool-8
Closed

[AIRFLOW-211] Fix JIRA "resolve" vs "close" behavior#1571
jlowin wants to merge 1 commit intoapache:masterfrom
jlowin:pr-tool-8

Conversation

@jlowin
Copy link
Member

@jlowin jlowin commented Jun 3, 2016

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

dev/airflow-pr Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these comment lines are more appropriate after the "Proceed with Airflow-211?" question, so this just moves them down.

@criccomini
Copy link
Contributor

LGTM but the commit msg needs fixing. :)

@codecov-io
Copy link

codecov-io commented Jun 3, 2016

Current coverage is 67.72%

Merging #1571 into master will not change coverage

@@             master      #1571   diff @@
==========================================
  Files           116        116          
  Lines          8285       8285          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5611       5611          
  Misses         2674       2674          
  Partials          0          0          

Powered by Codecov. Last updated by d32fb8d...0c0d8a6

@jlowin
Copy link
Member Author

jlowin commented Jun 4, 2016

@criccomini yes indeed it does :)

@criccomini
Copy link
Contributor

criccomini commented Jun 4, 2016

wait 207 or 211?

@jlowin
Copy link
Member Author

jlowin commented Jun 4, 2016

Shoot. Trying to do too many things at once. I'm glad you're more on top of this than I am...

@jlowin jlowin force-pushed the pr-tool-8 branch 2 times, most recently from 2786be3 to 8435a7b Compare June 4, 2016 16:08
@criccomini
Copy link
Contributor

LGTM

@asfgit asfgit closed this in c78101e Jun 4, 2016
@jlowin jlowin deleted the pr-tool-8 branch June 4, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants