Migrate dag js#15823
Merged
ryanahamilton merged 6 commits intoapache:masterfrom May 13, 2021
Merged
Conversation
boring-cyborg
Bot
added
area:UI
ryanahamilton
approved these changes
May 13, 2021
Contributor
ryanahamilton
left a comment
ryanahamilton
left a comment
There was a problem hiding this comment.
Looks great, thanks @bbovenzi 👏
github-actions
Bot
added
the
okay to merge
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
ryanahamilton
requested changes
May 13, 2021
Contributor
ryanahamilton
left a comment
ryanahamilton
left a comment
There was a problem hiding this comment.
Looks like some related test failures
show_external_log_redirect may be undefined. Wrapping <meta> tag in the if statement that was in javascript previously
ryanahamilton
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow we missed one file in #14115 of migrating all js from html files to their own files. It may have been blocked on other outstanding PRs that touched the UI.
This PR fixes that for
dag.html. Gantt, Tree, and Task Instance views also use some functions from dag.js, so that is now being imported a better way.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.