Closed
Conversation
jhtimmins
requested review from
ashb,
ephraimbuddy,
kaxil,
mik-laj,
ryanahamilton,
turbaszek and
vikramkoka
as code owners
This change gets rid of requests as core dependency. We have to change requests to become an optional dependency because it (so far) pulls in chardet as dependency and chardet is LGPL, which is not allowed to be mandatory dependency by ASF policies. More info here: https://issues.apache.org/jira/browse/LEGAL-572 The changes: * connexion is vendored-in (and requests usage is replaced with httpx) * Http Provider is turned into optional provider (not preinstalled) * Few places where requests were used in core and in cloud_sql provider which did not cause compatibility problem, it was replaced by httpx. * new extra added for deprecated experimental API (which is disabled by default and optional) * tests are fixed (using pytest-httpx fixture package) * The providers: http, airbyte, apache.livy, opsgenie, slack (all depend on http) now explicitely depend on `requirements`.
jhtimmins
force-pushed
the
vendor-in-connexion-test
branch
from
bd8c596 to
e239ac1
Compare
Member
|
We seemed to have some heavy problems with our CI infra. I am going to take a look at that today and fix as soon as the current MAJOR OUTAGE of Github Actions is solved :( https://www.githubstatus.com/incidents/zbpwygxwb3gw |
Member
|
Closing for now. I rebased my PR in the meantime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing @potiuk's branch #15781 to see if rebasing it on master will cause tests to pass.