Sandbox templates #15912
Merged
Sandbox templates #15912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates _shouldn't_ ever be taken from untrusted user input, but this
is a reasonable safety measure just in case someone does something
"clever".
This change does mean that templates can no longer access any attributes
that start with a `_`, i.e. `{{ obj._foo }}` would now fail
ashb
commented
May 18, 2021
| ) | ||
| jinja_env = jinja2.Environment( | ||
| loader=jinja2.FileSystemLoader(os.path.dirname(__file__)), autoescape=True | ||
| ) |
Member
Author
There was a problem hiding this comment.
This change was made because I was looking for all cases of jinaj2.Environment, and since 3 lines down we render fixed templates, we know it would never product a Native object, so we don't need it.
This change isn't required here, and I can split it out to a separate PR.
Member
|
No need to split. |
ashb
added a commit
that referenced
this pull request
May 18, 2021
Templates _shouldn't_ ever be taken from untrusted user input (and it's hard to do so without just edit the dag file, at which point you can run whatever python code you like _anyway_), but this is a reasonable safety measure just in case someone does something "clever". (cherry picked from commit 4295845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates shouldn't ever be taken from untrusted user input (and it's hard to do so without just edit the dag file, at which point you can run whatever python code you like anyway), but this is a reasonable safety measure just in case someone does something "clever".
This change does mean that templates can no longer access any attributes that start with a_, i.e.{{ obj._foo }}would now failThe second commit in this PR changes it so that
obj._foocontinues to work, to reduce chance of breaking existing dags.