Skip to content

Conversation

@drdenzy
Copy link
Contributor

@drdenzy drdenzy commented May 25, 2021

This PR aims to further improve Airflow Helm chart documentation.

It illustrates how connections, secrets, and environment variables can
be passed into Airflow using Helm chart.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Airflow Helm Chart docs.

This PR aims to further improve Airflow Helm chart documentation.
It illustrates how connections, secrets, and environment variables can
be passed to Airflow using Helm chart.
@drdenzy drdenzy requested a review from kaxil as a code owner May 25, 2021 15:30
@drdenzy drdenzy marked this pull request as draft May 25, 2021 15:33
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
drdenzy and others added 12 commits May 25, 2021 21:52
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@drdenzy drdenzy requested review from jedcunningham and kaxil May 25, 2021 20:10
@drdenzy drdenzy marked this pull request as ready for review May 25, 2021 20:10
drdenzy and others added 2 commits May 25, 2021 22:39
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 25, 2021
@kaxil kaxil merged commit 0686968 into apache:master May 25, 2021
@kaxil kaxil deleted the add-connections-and-variables-example-helm-chart-docs branch May 25, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants