Fix S3 Select payload join#16189
Conversation
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
left a comment
There was a problem hiding this comment.
Can you please add regression test for that ?
Do I understand correctly that it fixes the problem where the records split is in the middle of multi-byte character? If so it should be fairly easy to add unit test for.
|
Added commit. |
The original code has a potential bug that decodes fail if the payload is split in the middle of a multibyte character.
This can be avoided by joining and then decoding.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.