Fix formatting #16282
Closed
Fix formatting #16282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XD-DENG
reviewed
Jun 6, 2021
Member
XD-DENG
left a comment
XD-DENG
left a comment
There was a problem hiding this comment.
May you clarify why is this an issue?
Both formats are fine, aren't they?
Contributor
Author
|
The trailing comma is weird, it means the auto formatted form must be
multiline.
søn. 6. jun. 2021 kl. 11.43 skrev Xiaodong DENG ***@***.***>:
… ***@***.**** commented on this pull request.
May you clarify why is this an issue?
Both formats are fine, aren't they?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16282 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGOJJR3TAVDW3I332YCJLTRM7K3ANCNFSM46FSU5VQ>
.
|
Member
|
Wasn't this format used because of #16265 ? |
Contributor
Author
|
I think the story was that an upgrade to the automated formatted changed
how this syntax ought to be represented. I think a better fix then is to
remove the trailing comma altogether.
søn. 6. jun. 2021 kl. 17.16 skrev Tomek Urbaszek ***@***.***>:
… Wasn't this format used because of #16265
<#16265> ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16282 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGOJPPEDIMYE5VG7LHQ73TROGONANCNFSM46FSU5VQ>
.
|
Member
|
Close as won't fix. If black is happy with it then so are we. |
Contributor
Author
|
@ashb until the day where black is not happy because a trailing slash in function arguments is just weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.