Use safe get with AWS DMS describe replication tasks #16540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Visya
force-pushed
the
aws-dms-describe-tasks
branch
2 times, most recently
from
8f49cf4 to
36b371a
Compare
AWS DMS boto3 `describe_replication_tasks` omits `Marker` property in the response if no more tasks is available, it also omits `ReplicationTasks` property if no tasks is found.
Visya
force-pushed
the
aws-dms-describe-tasks
branch
from
36b371a to
9f1452a
Compare
potiuk
approved these changes
Jun 21, 2021
Jorricks
pushed a commit
to Jorricks/airflow
that referenced
this pull request
Jun 24, 2021
AWS DMS boto3 `describe_replication_tasks` omits `Marker` property in the response if no more tasks is available, it also omits `ReplicationTasks` property if no tasks is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS DMS boto3
describe_replication_tasksomitsMarkerproperty inthe response if no more tasks is available, it also omits
ReplicationTasksproperty if no tasks is found.In this case
describe_replication_tasksfunction in DmsHook will fail, so it's better to use safe get.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.