Add error message to dag dependency view #16711
Conversation
Sometimes the node and edge data don't load. In that case we will show an error message to the user as opposed to just a blank screen.
boring-cyborg
bot
added
area:UI
| // Sometimes the data doesn't load when the scheduler isn't running. | ||
| if (!nodes.length) { | ||
| $('#error').show(); | ||
| $('#error_msg').text('There was an issue loading dependencies. Make sure everything is up and running, then try again.'); |
There was a problem hiding this comment.
Does this message show up if everything is running but there are just no dags?
(I.e. if Load_examples is false but scheduler is up)
There was a problem hiding this comment.
I'll update the copy to say make sure you have dags.
| $('#error').show(); | ||
| $('#error_msg').text(` | ||
| There was an issue loading dependencies. | ||
| Make sure you have dags loaded and that everything is running, then try again. |
There was a problem hiding this comment.
I'm still not happy with this case when there are no DAGs -- i.e. a fresh install with out any dags, and with load_examples off -- in that case it shouldn't really show an error; it should just show nothing.
There was a problem hiding this comment.
I agree. I was trying to keep it simple, but that didn't work out. I'll have it check if there are any dags before showing an error.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Closing this since this all should be handled in a better way. |
2 participants
Sometimes the node and edge data don't load. In that case we will show an error message to the user as opposed to just a blank screen.
Short term fix for #16610
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.