Fix for integer division fencepost error on S3 chunked transfers #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airflow/hooks/S3_hook.py
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from future import division |
There was a problem hiding this comment.
Shouldn't this be __future__? I might be wrong as I have yet to move to py3
Contributor
|
LGTM |
Current coverage is 64.40% (diff: 100%)@@ master #1683 diff @@
==========================================
Files 123 123
Lines 8699 8700 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5601 5603 +2
+ Misses 3098 3097 -1
Partials 0 0
|
Contributor
|
@clearclaw, please squash commits. |
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
Fix integer division fencepost error on S3 chunked transfers Closes apache#1683 from clearclaw/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/AIRFLOW-362