Skip to content

Conversation

@josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Jul 8, 2021

Related to #10285

  • Updated example DAG files such that xcom_pull() calls use an operator's .output property
  • Added comments to which task dependencies, if any, are handled and/or created via XComArgs for transparency
  • Removed or refactored the default_args pattern where necessary as requested by @ashb (i.e. removed a separated default_args declaration for deference for declaration as part of the DAG object)

Note: There are several instances where the xcom_pull() call was not updated. These instances involve accessing a specific value within the XCom or calling user-defined macros with an XCom value. Reference #16618 for an open issue to enhance the XComArg functionality to provide similar behavior as the classic xcom_pull() method.

Note: Not all DAGs were tested functionally (i.e. with hard integrations to source systems and executed), however each DAG was tested to compile and generate a DAG graph as expected locally.

An detailed summary of all changes made as part of this PR can be found below:

DAG File Converted xcom_pull()? Other Updates? Comments
airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py Yes Yes Removed explicit task dependencies that are created via XComArgs.

Removed unneeded default_args pattern.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jul 8, 2021
@ashb ashb merged commit 1e1b212 into apache:main Jul 8, 2021
@josh-fell josh-fell deleted the xcomarg-update-example-dags-airbyte branch July 8, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants