Skip to content

Conversation

@josh-fell
Copy link
Contributor

Related to #10285

  • Updated example DAG files such that xcom_pull() calls use an operator's .output property
  • Added comments to which task dependencies, if any, are handled and/or created via XComArgs for transparency
  • Removed or refactored the default_args pattern where necessary as requested by @ashb (i.e. removed a separated default_args declaration for deference for declaration as part of the DAG object)
  • Other miscellaneous updates based on .output refactoring

Note: There are several instances where the xcom_pull() call was not updated. These instances involve accessing a specific value within the XCom or calling user-defined macros with an XCom value. Reference #16618 for an open issue to enhance the XComArg functionality to provide similar behavior as the classic xcom_pull() method.

Note: Not all DAGs were tested functionally (i.e. with hard integrations to source systems and executed), however each DAG was tested to compile and generate a DAG graph as expected locally.

An detailed summary of all changes made as part of this PR can be found below:

DAG File Converted xcom_pull()? Other Updates? Comments
airflow/providers/jenkins/example_dags/example_jenkins_job_trigger.py Yes Yes Removed explicit task dependencies that are created via XComArgs.

Refactored grab_artifact_from_jenkins() function to take an input XComArgs from a previous task.

Refactored default_args pattern.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@josh-fell josh-fell force-pushed the xcomarg-update-example-dags-jenkins branch from 388a945 to da61456 Compare July 21, 2021 17:33
@josh-fell josh-fell force-pushed the xcomarg-update-example-dags-jenkins branch from da61456 to 75ee83c Compare July 26, 2021 14:23
@potiuk potiuk merged commit a777537 into apache:main Jul 26, 2021
@josh-fell josh-fell deleted the xcomarg-update-example-dags-jenkins branch July 26, 2021 19:44
nathadfield pushed a commit to king/airflow that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants