Remove cache for kubernetes tests#16927
Conversation
potiuk
added
the
full tests needed
potiuk
force-pushed
the
remove-cache-for-k8s-test-virtualenv
branch
from
aaff222 to
3e17f73
Compare
potiuk
changed the title
|
Hey @ephraimbuddy -> I think this is the final reason for K8S tests failing for 'main` repo. I think the venv cache has been irreparably broken by some early attempts of running the tests. I am rebuilding the cache from scratch with this PR and hopefully the "main" K8S tests will finally get green as well. |
|
The tests in main were failing with (https://github.com/apache/airflow/runs/3039240162?check_suite_focus=true#step:8:1585)
Because the python3 binary was missing from the cache (I believe) Let's see if it helps. Another hypothesis I had was that the python3 symbolic link is not properly stored in the cache of GitHub Actions. So if that one does not work we can simply disable the cache altogether (it does not take that long to build airflow's venv with [cncf.kubernetes, devel] extra only, and this is what the venv really is - it is needed to run all the k8s tests. |
potiuk
force-pushed
the
remove-cache-for-k8s-test-virtualenv
branch
2 times, most recently
from
e896297 to
33eb85d
Compare
|
Yeah. Removing cache is best. We are also running different K8S for different python versions and this makes the attempts to cache the venv really bad idea. |
potiuk
changed the title
potiuk
force-pushed
the
remove-cache-for-k8s-test-virtualenv
branch
from
33eb85d to
2bc40c2
Compare
potiuk
force-pushed
the
remove-cache-for-k8s-test-virtualenv
branch
from
2bc40c2 to
279beaf
Compare
|
It works, but I forgot that the "upgrade" test had it's own cache. Removed it too. |
Different python versions are used for different tests for k8s so we should not attempt to cache the venv for tests, otherwise they will randomly fail.
potiuk
force-pushed
the
remove-cache-for-k8s-test-virtualenv
branch
from
279beaf to
ea5799d
Compare
ephraimbuddy
left a comment
ephraimbuddy
left a comment
There was a problem hiding this comment.
Nice. I have a PR I have not merged because of failing helm tests!
Go ahead :) |
Different python versions are used for different tests for k8s so we should not attempt to cache the venv for tests, otherwise they will randomly fail. (cherry picked from commit e8e9a6d)
Different python versions are used for different tests for k8s so we should not attempt to cache the venv for tests, otherwise they will randomly fail.
Different python versions are used for different tests for k8s so we should not attempt to cache the venv for tests, otherwise they will randomly fail. (cherry picked from commit e8e9a6d)
Different python versions are used for different tests for k8s so we should not attempt to cache the venv for tests, otherwise they will randomly fail. (cherry picked from commit e8e9a6d)
3 participants
Different python versions are used for different tests for k8s
so we should not attempt to cache the venv for tests, otherwise
they will randomly fail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.