Fixed parsing issue of _docker.env file for docker-compose v2 #16950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh boy! |
Member
|
🤦 for docker v2 to not handle this case. I think we should open an issue for that |
Member
|
I tested it with docker 2 and it works there too. Thanks for that investigation and fix @oyarushe ! |
potiuk
approved these changes
Jul 12, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Member
|
Created an issue in docker-archive/compose-cli#1917 |
Member
|
BTW. You will need to rebase to latest main to get it works (drill operator added a dependency) |
Member
|
I merge it anyway - no problem with the failing tests. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 13, 2021
The apache#16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2.
potiuk
added a commit
that referenced
this pull request
Jul 13, 2021
The #16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2.
potiuk
pushed a commit
that referenced
this pull request
Jul 18, 2021
(cherry picked from commit 83cb237)
potiuk
added a commit
that referenced
this pull request
Jul 18, 2021
The #16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2. (cherry picked from commit 72781c0)
josh-fell
pushed a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
josh-fell
pushed a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
The apache#16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2.
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
(cherry picked from commit 83cb237)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
The #16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2. (cherry picked from commit 72781c0)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
(cherry picked from commit 83cb237)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
The #16950 aimed to fix an incompatibility introduced by beta version of docker-compose v2 (which is automatically pushed to MacOS users now). The issue is documented in docker-archive/compose-cli#1917 Unfortunately it has an undesired side-effect that the same file cannot be used to specify list of variables for docker command (the variables come empty). Until the problem is solved, we need to keep two copies of those variable files. Not ideal, but hopefully the issue will be solved soon and we can go back to original env file in docker-compose v2. (cherry picked from commit 72781c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It relates to issue #16949. It can't parse env file without sign
=for each variable name.I have checked for versions of Docker Compose:
1.29.2andv2.0.0-beta.6.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.