Skip to content

Update graph.css#17128

Closed
chenjiahui wants to merge 3 commits into
apache:mainfrom
chenjiahui:patch-1
Closed

Update graph.css#17128
chenjiahui wants to merge 3 commits into
apache:mainfrom
chenjiahui:patch-1

Conversation

@chenjiahui
Copy link
Copy Markdown

In some cases, the task_instancetask_instance gets a state of scheduled, so we need to provide a style for this state. Otherwise, we can't to know which node is currently in progress.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

In some cases, the task_instancetask_instance gets a state of scheduled, so we need to provide a style for this state. Otherwise, we can't to know which node is currently in progress.
@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 21, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Jul 21, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@chenjiahui chenjiahui closed this Jul 21, 2021
@chenjiahui chenjiahui reopened this Jul 21, 2021
Comment thread airflow/www/static/css/graph.css Outdated
}

g.node.scheduled rect{
stroke: green;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stroke: green;
stroke: green;

@chenjiahui chenjiahui closed this Jul 22, 2021
@chenjiahui chenjiahui deleted the patch-1 branch July 22, 2021 12:36
@chenjiahui chenjiahui restored the patch-1 branch July 22, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants