Skip to content

Update hasicorp-vault.rst to describe use of config#17313

Merged
potiuk merged 1 commit intoapache:mainfrom
sadan:patch-1
Aug 1, 2021
Merged

Update hasicorp-vault.rst to describe use of config#17313
potiuk merged 1 commit intoapache:mainfrom
sadan:patch-1

Conversation

@sadan
Copy link
Copy Markdown
Contributor

@sadan sadan commented Jul 29, 2021

This page shows use of Hashicorp Vault to use for Connections and Variables. But we can also use it for storing some of the attributes from Airflow configuration file. There is no concrete example for the latter use-case in the documentation.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

This page shows use of Hashicorp Vault to use for Connections and Variables. But we can also use it for storing some of the attributes from Airflow configuration file. There is no concrete example for the latter use-case in the documentation.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jul 29, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@github-actions
Copy link
Copy Markdown

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jul 29, 2021
@potiuk potiuk merged commit 8fa4a8b into apache:main Aug 1, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Aug 1, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants