Fix failing test on MSSQL #17334
Merged
Fix failing test on MSSQL #17334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the failing test on MSSQL by disposing and creating a new connection so as to use the new connection to make queries
boring-cyborg
bot
added
the
area:Scheduler
Member
|
Flaky tests failure (and static check fixed elsewehere ) but looks good to me. |
potiuk
approved these changes
Jul 30, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ephraimbuddy
force-pushed
the
fix-mssql-test
branch
from
7d06c34 to
b6297e4
Compare
potiuk
approved these changes
Jul 30, 2021
Member
|
🤞 |
Contributor
Author
|
One failing test but that's on schedulerJob and I have seen it fail in some other PRs. Maybe we should quarantine it ... |
Member
|
Have not seen that one before but looks like prone to races :D |
Contributor
Author
Probably,...I will merge this and watch the scheduler test in other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the failing test on MSSQL by disposing and creating a new connection
so as to use the new connection to make queries.
Also, timeouts on process join was removed because it's flaky
Closes: #17326
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.