Skip to content

Conversation

@pyerbiz
Copy link
Contributor

@pyerbiz pyerbiz commented Jul 31, 2021

Adding documentation and example dags for missing cases in Azure Providers.

closes: #11912
related:

# :type options: dict
# :param azure_data_explorer_conn_id: Reference to the
# :ref:`Azure Data Explorer connection<howto/connection:adx>`.
# :type azure_data_explorer_conn_id: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining the above parameters here would be problematic. For example, if there's an addition to the params, we may forget to update the param list here

Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make each example have a system test too; that way, we can confirm that the example works.

Here's an example system test: https://github.com/apache/airflow/blob/main/tests/providers/microsoft/azure/operators/test_adls_delete_system.py

So I suggest we take this, one example and a system test at a time

@pyerbiz
Copy link
Contributor Author

pyerbiz commented Sep 6, 2021

I am back from a work and travel hiatus. If still acceptable, maintainers may re-assign this issue to me.

@uranusjr
Copy link
Member

uranusjr commented Sep 6, 2021

You’re still assigned in the issue, please feel free to continue.

@kaxil
Copy link
Member

kaxil commented Sep 20, 2021

@pyerbiz Do you need any help with this issue

@pyerbiz
Copy link
Contributor Author

pyerbiz commented Sep 20, 2021

@kaxil Not right now. I'll try to this weekend and seek help if I need it.

pyerbiz and others added 12 commits September 22, 2021 11:05
#16730 (#1)

* created files

* added s3tosftp and examples

* vault var removed

* updated s3_to_sftp example and doc

* fixed directives

* ref error fixed
…Operator.

* created files

* added s3tosftp and examples

* vault var removed

* updated s3_to_sftp example and doc

* fixed directives

* ref error fixed

* ran static checks
@pyerbiz
Copy link
Contributor Author

pyerbiz commented Sep 26, 2021

@kaxil I had a question about the example_dag for adx.py.

I am using gcp's big query docs for reference and also the postgres operator doc. Based on them, to make a complete example I should be able to create table, load data, query data, and drop table. I have to tried to do that in kusto above. I am concerned about the connection_string_id used to connect to ADX cluster. When I access adx with python in my local machine, I have to do the browser pop-up method, credential based login -- other methods have caused me problems in the past. I'm going to try using the AAD token method again and see if that works without pop-ups. Is there a preferred way users do adx authentication on airflow? I ask because the other example_dag files for azure all use a default "default_connection_id" string to show the example.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 10, 2021
@github-actions github-actions bot closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:microsoft-azure Azure-related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add how-to Guide for Azure operators

4 participants