Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 10, 2021

This had no negative effect because we only run trino during
integration tests but it could actually prevent two integration
tests run in parallel on the same machine if we choose otherwise
and it will look better in logs:

NAME
airflow-integration-mysql_pinot_1
airflow-integration-mysql_statsd-exporter_1
airflow-integration-mysql_redis_1
airflow-integration-mysql_mysql_1
airflow-integration-mysql_cassandra_1
airflow-integration-mysql_grafana_1
airflow-integration-mysql_openldap_1
trino
airflow-integration-mysql_kdc-server-example-com_1
airflow-integration-mysql_mongo_1
airflow-integration-mysql_rabbitmq_1
airflow-integration-mysql_airflow_run_908822c9c10f

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

This had no negative effect because we only run trino during
integration tests but it could actually prevent two integration
tests run in parallel on the same machine if we choose otherwise
and it will look better in logs:

```
NAME
airflow-integration-mysql_pinot_1
airflow-integration-mysql_statsd-exporter_1
airflow-integration-mysql_redis_1
airflow-integration-mysql_mysql_1
airflow-integration-mysql_cassandra_1
airflow-integration-mysql_grafana_1
airflow-integration-mysql_openldap_1
trino
airflow-integration-mysql_kdc-server-example-com_1
airflow-integration-mysql_mongo_1
airflow-integration-mysql_rabbitmq_1
airflow-integration-mysql_airflow_run_908822c9c10f
```
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 10, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit bd0a3d5 into apache:main Aug 10, 2021
@potiuk potiuk deleted the remove-hardcoded-container-name-for-trino branch August 10, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants