Skip to content

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 17, 2021

google-auth recently published a 2.0.0 release which removed support for Python 2.7. google-auth now requires Python >=3.6. No other breaking changes were made. You can see the full list of changes here.

I am opening PRs to expand google-auth version ranges for packages that meet either of the following criteria:

  • Package has >10,000 monthly downloads as of June 2021
  • Package is owned by a Google team

google-auth is a dependency of many different libraries that interact with Google APIs. Increasing the time and number of packages with compatible pins on google-auth lowers the chance end developers who use multiple libraries will see dependency conflicts.

If possible, please do not require google-auth>=2.0.0 or google-api-core>=2.0.0 until googleapis/google-cloud-python#10566 is resolved, as that will further reduce the likelihood of diamond dependency conflicts.

Googlers, see this doc for more information.

Given the number of google-cloud-* packages this library pins directly I also bumped the pin on google-api-core to < 3.

Constraints files: I looked at https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pinned-constraint-files but am not quite sure what that means for this change.

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Aug 17, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 17, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@busunkim96 busunkim96 changed the title Allow google-auth < 3 Allow google-auth < 3 and google-api-core < 3 Aug 19, 2021
@busunkim96 busunkim96 marked this pull request as ready for review August 19, 2021 19:20
@leahecole leahecole requested a review from uranusjr August 27, 2021 18:47
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 27, 2021
@potiuk potiuk merged commit 220678d into apache:main Aug 27, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 27, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants