Skip to content

[AIRFLOW-469] Add MFG Labs as Airflow user#1768

Closed
dud225 wants to merge 1 commit into
apache:masterfrom
dud225:patch-1
Closed

[AIRFLOW-469] Add MFG Labs as Airflow user#1768
dud225 wants to merge 1 commit into
apache:masterfrom
dud225:patch-1

Conversation

@dud225
Copy link
Copy Markdown
Contributor

@dud225 dud225 commented Aug 30, 2016

Hello.

We'd like to be added as official Airflow users.

Regards

@codecov-io
Copy link
Copy Markdown

Current coverage is 65.46% (diff: 100%)

Merging #1768 into master will decrease coverage by 0.03%

@@             master      #1768   diff @@
==========================================
  Files           142        142          
  Lines          9883       9883          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6473       6470     -3   
- Misses         3410       3413     +3   
  Partials          0          0          

Powered by Codecov. Last update d649cfa...bb43cb2

@bolkedebruin
Copy link
Copy Markdown
Contributor

Welcome! But could you make sure to use the alphabetical order?

@r39132
Copy link
Copy Markdown
Contributor

r39132 commented Sep 1, 2016

@dud225 ? As mentioned, please add your company to the list while maintaining alphanumeric ordering.

@dud225
Copy link
Copy Markdown
Contributor Author

dud225 commented Sep 6, 2016

Sorry for that didn't notice it in the first place.

@r39132
Copy link
Copy Markdown
Contributor

r39132 commented Sep 7, 2016

@dud225 You need to rebase.. looks like quite a few companies added their names while this was left open.

@r39132
Copy link
Copy Markdown
Contributor

r39132 commented Sep 7, 2016

Also, in general, you need to squash your commits, though committers can also do it with the airflow-pr tool, but it's something we also wish contributors to do.

@r39132
Copy link
Copy Markdown
Contributor

r39132 commented Sep 8, 2016

@dud225 just a warning that I will be closing this PR unless there is movement on this.

@msumit
Copy link
Copy Markdown
Contributor

msumit commented Sep 9, 2016

@dud225 plz resolve the conflicts and rebase to squash all your commits in a single commit.

@dud225
Copy link
Copy Markdown
Contributor Author

dud225 commented Sep 9, 2016

Sorry for the late reply.
Here you are.

@ldct
Copy link
Copy Markdown
Contributor

ldct commented Sep 11, 2016

👍

@asfgit asfgit closed this in afed622 Sep 11, 2016
@dud225 dud225 deleted the patch-1 branch September 12, 2016 07:15
alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
Hello.

We'd like to be added as official Airflow users.

Regards

Closes apache#1768 from dud225/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants