Improve MySqlToHiveOperator tests #17958
Conversation
These tests were actually just testing the hook again (by checking the command executed) but were asserting nothing about the CSV passed to the hook. This change makes the operator tests check the logic in the operator and no longer tests the hook code again. `test_mysql_to_hive_verify_loaded_values` was removed as since we removed Java/a real hive CLI from our tests this has only been testing our mock, not the real code.
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
I don’t understand what the old tests are doing and can’t say if the new ones are covering everything they do, but the new tests look good to me.
| cur.execute("INSERT INTO baby_names VALUES(%s, %s, %s, %s);", row) | ||
|
|
||
| def tearDown(self): | ||
| conn.commit() |
There was a problem hiding this comment.
| conn.commit() | |
| cur.commit() |
?
There was a problem hiding this comment.
conn.commit does work -- I don't think you commit a cursor.
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
Yeah, the old tests got nerfed without us really noticing a while ago. |
2 participants
These tests were actually just testing the hook again (by checking the
command executed) but were asserting nothing about the CSV passed to the
hook.
This change makes the operator tests check the logic in the operator and
no longer tests the hook code again.
test_mysql_to_hive_verify_loaded_valueswas removed as since weremoved Java/a real hive CLI from our tests this has only been testing
our mock, not the real code.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.