Increase timeouts for setup/teardown in pytest #18505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reason recently some tests started to fail on setup timout exceeding 20 seconds. Those tests have NO setup so it likely a side-effect of other tests (for example with some process cleanup that takes more time/CPU. This change attempts to fix it by simply increasing the timeout to 60 seconds. If it works - fine, but if not, it will be indication that we have a deeper problem to fix.
potiuk
requested review from
ephraimbuddy,
kaxil,
mik-laj,
turbaszek and
uranusjr
ashb
approved these changes
Sep 24, 2021
kaxil
reviewed
Sep 24, 2021
| "--timeouts-order" | ||
| "moi" | ||
| "--setup-timeout=20" | ||
| "--setup-timeout=60" |
Member
There was a problem hiding this comment.
Indeed, setup-timeout of more than 20-30s seems very odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason recently some tests started to fail
on setup timout exceeding 20 seconds. Those tests have NO setup
so it likely a side-effect of other tests (for example with some
process cleanup that takes more time/CPU.
This change attempts to fix it by simply increasing the timeout
to 60 seconds. If it works - fine, but if not, it will be indication
that we have a deeper problem to fix.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.