-
Notifications
You must be signed in to change notification settings - Fork 16.4k
doc: Added notification into this guide to help developer solve "dock… #18524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Added notification into this guide to help developer solve "dock… #18524
Conversation
…er-credential-secretservice" error.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we can rewrite the first two notes into one so the same content is not repeated twice.
Edit: The repeated content is under PyCharm and VSCode setup instructions so I guess it's fine.
|
Also: Could you reformat the commit message to conform to the general Git commit format? |
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Awesome work, congrats on your first merged pull request! |
Added notifications into CONTRIBUTORS_USER_QUICKSTART to help developers when they encounter docker credential error.