Skip to content

Conversation

@kevin1kevin1k
Copy link
Contributor

@potiuk
Copy link
Member

potiuk commented Sep 26, 2021

Looks good. Let me close and reopen to rebuild

@potiuk potiuk closed this Sep 26, 2021
@potiuk potiuk reopened this Sep 26, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 26, 2021
@potiuk
Copy link
Member

potiuk commented Sep 26, 2021

Would be cool to have 4 PRS merged after the workshops !

@kevin1kevin1k
Copy link
Contributor Author

Thanks again, really enjoyed the sprint today!

@potiuk
Copy link
Member

potiuk commented Sep 26, 2021

Cool - one thing to fix - we are building an inventory of howto guides so you need to add it to ariflow/providers/slack/provider.yaml (see other providers for an example).

@kevin1kevin1k
Copy link
Contributor Author

No problem, hopefully the new commit would fix that :)

@potiuk potiuk merged commit 29493d2 into apache:main Sep 26, 2021
@potiuk
Copy link
Member

potiuk commented Sep 26, 2021

Cool @kevin1kevin1k ! Thanks for the participation in the workshop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants