-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Broken links on documentation site for Official Helm Chart #18682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The broken link shown is https://airflow.apache.org/docs/helm-chart/latest/index.html which results in a 404 Not Found in the browser when clicked on from this page: https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#using-official-airflow-helm-chart (NOTE: there maybe other locations pointing to the official helm chart in the docs such as on this page: https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#production-readiness ) Not sure what the exact fix needs to be throughout, but here's the file I saw that is the likely generator (.rst restructured text) for the index.html https://github.com/apache/airflow/blob/main/docs/helm-chart/index.rst
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
@jedcunningham did you use for production option? Development docs is generated in airflow/docs/exts/airflow_intersphinx.py Line 73 in 10421c6
|
That sounds like a but - this is the "airflow" documentation referring the 'helm-chart" one and I think this might depend on whether you build it separately or together (this is might wild guess)? |
|
Yeah this is a separate issue since this is when publishing Airflow docs not the Helm Chart -- we will tackle it separately. Thanks for notifying us @thadguidry |
|
Yep. I think it was when airflow was generated with prod, after helm chart was generated with dev. I will fix it (I think it was me who pushed it last time). |
The PR #17286 has not been cherry-picked to v2-1-test branch which resulted in links to Helm Chart were to "latest" rather than "stable" URL. The documentation has been regenerated after cherry-picking it. Fixes: apache/airflow#18682
The PR #17286 has not been cherry-picked to v2-1-test branch which resulted in links to Helm Chart were to "latest" rather than "stable" URL. The documentation has been regenerated after cherry-picking it. Fixes: apache/airflow#18682
The PR #17286 has not been cherry-picked to v2-1-test branch which resulted in links to Helm Chart were to "latest" rather than "stable" URL. The documentation has been regenerated after cherry-picking it. Fixes: apache/airflow#18682
The broken link shown is https://airflow.apache.org/docs/helm-chart/latest/index.html which results in a 404 Not Found in the browser when clicked on from this page:
https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#using-official-airflow-helm-chart
(NOTE: there maybe other locations pointing to the official helm chart in the docs such as on this page: https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#production-readiness )
Not sure what the exact fix needs to be throughout, but here's the file I saw that is the likely generator (.rst restructured text) for the index.html
https://github.com/apache/airflow/blob/main/docs/helm-chart/index.rst
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.