Skip to content

Conversation

@thadguidry
Copy link

The broken link shown is https://airflow.apache.org/docs/helm-chart/latest/index.html which results in a 404 Not Found in the browser when clicked on from this page:
https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#using-official-airflow-helm-chart
(NOTE: there maybe other locations pointing to the official helm chart in the docs such as on this page: https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#production-readiness )

Not sure what the exact fix needs to be throughout, but here's the file I saw that is the likely generator (.rst restructured text) for the index.html
https://github.com/apache/airflow/blob/main/docs/helm-chart/index.rst


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The broken link shown is https://airflow.apache.org/docs/helm-chart/latest/index.html which results in a 404 Not Found in the browser when clicked on from this page:
https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#using-official-airflow-helm-chart
(NOTE: there maybe other locations pointing to the official helm chart in the docs such as on this page: https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#production-readiness )

Not sure what the exact fix needs to be throughout, but here's the file I saw that is the likely generator (.rst restructured text) for the index.html
https://github.com/apache/airflow/blob/main/docs/helm-chart/index.rst
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@mik-laj
Copy link
Member

mik-laj commented Oct 2, 2021

@jedcunningham did you use for production option? Development docs is generated in latest directory.

f'/docs/{pkg_name}/{"stable" if for_production else "latest"}/',

@potiuk
Copy link
Member

potiuk commented Oct 3, 2021

@jedcunningham did you use for production option? Development docs is generated in latest directory.

f'/docs/{pkg_name}/{"stable" if for_production else "latest"}/',

That sounds like a but - this is the "airflow" documentation referring the 'helm-chart" one and I think this might depend on whether you build it separately or together (this is might wild guess)?

@kaxil
Copy link
Member

kaxil commented Oct 4, 2021

Yeah this is a separate issue since this is when publishing Airflow docs not the Helm Chart -- we will tackle it separately.

Thanks for notifying us @thadguidry

@kaxil kaxil closed this Oct 4, 2021
@potiuk
Copy link
Member

potiuk commented Oct 4, 2021

Yep. I think it was when airflow was generated with prod, after helm chart was generated with dev. I will fix it (I think it was me who pushed it last time).

potiuk added a commit to apache/airflow-site that referenced this pull request Oct 4, 2021
The PR #17286 has not been cherry-picked to v2-1-test branch
which resulted in links to Helm Chart were to "latest" rather
than "stable" URL.

The documentation has been regenerated after cherry-picking it.

Fixes: apache/airflow#18682
potiuk added a commit to apache/airflow-site that referenced this pull request Oct 4, 2021
The PR #17286 has not been cherry-picked to v2-1-test branch
which resulted in links to Helm Chart were to "latest" rather
than "stable" URL.

The documentation has been regenerated after cherry-picking it.

Fixes: apache/airflow#18682
potiuk added a commit to apache/airflow-site that referenced this pull request Jun 17, 2023
The PR #17286 has not been cherry-picked to v2-1-test branch
which resulted in links to Helm Chart were to "latest" rather
than "stable" URL.

The documentation has been regenerated after cherry-picking it.

Fixes: apache/airflow#18682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants